Skip to content

Fix Slack slash commands using relative URL

What does this MR do?

As reported in this comment: gitlab-mattermost#101 (comment 310769792), Slack and Mattermost slash commands integration sometimes uses the author avatar with a relative path which causes the image to show up as broken when displayed from a different domain (most of the time).

This MR adds an absolute link to the same.

Screenshots

Integration Before After
Slack Screen_Shot_2020-04-10_at_14.59.07 Screen_Shot_2020-04-10_at_14.59.19
Mattermost Screen_Shot_2020-04-10_at_15.05.04 Screen_Shot_2020-04-10_at_15.03.31

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading