Disable `setup_reader` to prevent flaky spec in `lib/gitlab/import_export/project/tree_restorer_spec`
What does this MR do?
Disables setup_reader
which potentially cause flaky tests when feature flag misbehaves (Original discussion in #213793 (comment 319730517)).
Without setup_reader
, the reader would fall back to legacy_relation_reader
, and the test would continue as if it is testing legacy_relation_reader
.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Albert Salim