Display indicator to rule name
What does this MR do?
Display Indicator in the Approval Rules
Testing Case
Setup
Let's setup our rules in the project settings
- Go to Settings > General > expand "Merge request approvals"
- Add a new approval rule
- Create a new rule named "Project Rule" and target it to any branch
- Create a new rule named "Project Rule 2" and target it to any branch
Edit Rule
(You might need to create a new MR if you don't have any)
- Find a MR and click "edit"
- Edit your MR so it looks like this and click "Save changes"
- Once you click save changes it will navigate to your MR
- Click "edit"
-
Your approval rules should look like this: -
There is an "Overridden" indicator on the project setting rule you edited -
There is an "Added for this merge request" indicator on the new local rule you created
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #199795 (closed)
Edited by 🤖 GitLab Bot 🤖