Skip to content

#212848 Removed UltraAuth integration for OmniAuth

Kartikey Tanna requested to merge tannakartikey/gitlab:212848 into master

What does this MR do?

It removes UltraAuth integration for OmniAuth introduced in gitlab-foss!26348 (merged) and gitlab-foss!28941 (merged)

Resolves #212848 (closed)

Screenshots

database query plans

db/migrate/20200508021128_remove_ultraauth_provider_from_identities.rb

Query:

DELETE FROM identities WHERE provider = 'ultraauth';

Plan: https://explain.depesz.com/s/pJnl

Recommendations (internal):

Query processes too much data to return a relatively small number of rows. – Reduce data cardinality as early as possible during the execution, using one or several of the following techniques: new indexes, partitioning, query rewriting, denormalization. See the visualization of the plan to understand which plan nodes are the main bottlenecks.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading