Skip to content

Multiline comments frontend MVC inline only

Justin Boyson requested to merge jdb/mutliline-comment-fe into master

What does this MR do?

This is the proof of concept for the first iteration of multiline comments.

Related to #211255 (closed)

Related to #213010 (closed)

To test this feature you need to enable :multiline_comments

Feature.enable(:multiline_comments)

NOTE

This will save comments for both inline and side by side, but the line counts are off for side by side. In the spirit of iteration let's only review this from the inline perspective and submit a second MR for parallel.

Screenshots

Save comment form

image

Comment on only a single line

Notice there is no "X to X" verbiage

image

Multiline comment saved, showing which lines are commented on

image

Multiline comment in pending state

image

Pending comments list

image

Does this MR meet the acceptance criteria?

Conformity

Edited by Phil Hughes

Merge request reports

Loading