Fix custom metrics dashboard when max_value is set
What does this MR do?
Resolves #214360 (closed)
Dashboard failed to load, because new attribute max_value
added to panel wasn't added to https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/models/performance_monitoring/prometheus_panel.rb which caused errors.
In order to address that I've added missing attribute and updated specs. Also to prevent such regression from happening in the future I've added error handling to dashboard processing stage, to allow it to fail in less impactful way.
In the end I've added failing stage PanelIdInserter
into https://gitlab.com/gitlab-org/gitlab/-/blob/master/spec/lib/gitlab/metrics/dashboard/processor_spec.rb to improve integration testing, which should also help detecting similar regression in the future.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team