Skip to content

Resolve "Padding in snippet blob header" #212549

What does this MR do?

Fix minor spacing issue at Snippet blob viewer

Prior to this change,

Issue

The padding between the two button groups in the header of a blob view for snippets is an HTML whitespace, so about 3.95px. According to Pajamas, spacing for this should actually be 8px.

How issue is resolved? After enabling Vue Snippet, the horizontal margin was set using mx-2 class to button group. the extra inline spacing was removed by making the parent class as flexbox.

Changes made in following files : blob_header_viewer_switcher.vue - adding right padding blob_header.vue - making the header element as flex

Tested the behavior for the Markdown files (.md and .markdown) and for non-md files ( .js, .rb, .html files) spacing occurs as expected.

Screenshots

snippets

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #212549 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading