Add comment_detail column to services
What does this MR do?
Issue #195887 (closed)
- Add the database migration
- Add the enum model
- Add as parameter inside the controller
Context: This is the first MR of work towards the issue. There will be follow up backend and frontend MRs.
Screenshots
br db:migrate:up VERSION=20200410104828
== 20200410104828 AddCommentDetailToServices: migrating =======================
-- add_column(:services, :comment_detail, :smallint)
-> 0.0012s
== 20200410104828 AddCommentDetailToServices: migrated (0.0013s) ==============
br db:migrate:down VERSION=20200410104828
== 20200410104828 AddCommentDetailToServices: reverting =======================
-- remove_column(:services, :comment_detail)
-> 0.0039s
== 20200410104828 AddCommentDetailToServices: reverted (0.0039s) ==============
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖