Skip to content

Added QA selectors to Snippet edit form fields

Denys Mishunov requested to merge 215031-update-qa-selectors into master

What does this MR do?

After refactoring the Snippet edit form to Vue, some QA selectors are missing failing the QA tests. This MR is an attempt to fix this.

Some background into the cause for this MR

I was working on refactoring Snippet Edit Form to Vue. This is the refactoring behind a feature flag. All flags are disabled in QA tests by default (contrary to feature tests, where it’s opposite: all the flags are enabled by default). This means that my MR for the refactoring didn’t ring any bell while runing in the pipeline. However, in order to verify that the refactor was successful, I had to enable the feature flag on staging. And here is where things went bad: due to this, QA test (create_snippet_spec.rb) on staging failed. This was alarming as it’s too close to production but after all, the damage wasn’t caused as, again, the test fails only when the flag is on. However, the test had to be quarantined in order to not cause all of the pipelines in staging fail 🙈

Now, this MR is a fix for this situation where I put back some missing QA selectors, updated some to the accepted conventions and adjusted the general QA story of the refactoring.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #215031 (closed)

Edited by Denys Mishunov

Merge request reports