Prevent an issue where dropdown links would not be clickable
What does this MR do?
This MR fixes an issue where links in the navbar search Dropdown would not be clickable.
The search_autocomplete.js#disableAutocomplete
function was causing a re-initialization of the Bootstrap Dropdown via the jQuery plugin when triggering the toggle
event on the wrong instance.
In fact, we are creating the Dropdown
instance on a children of this element with the glDropdown
component, and the autocomplete code was using the wrong reference.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
- [-] Code review guidelines
- [-] Merge request performance guidelines
- [-] Style guides
- [-] Database guides
-
Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
-
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖