Skip to content

Remove quarantine new status from existing tests

Zeff Morgan requested to merge qa-remove-quarantine-new into master

What does this MR do?

Remove quarantine: { type: :new } from new tests.

Discussion in quality meeting around issues this is causing led to this decision. Tests are staying in quarantine:new longer than expected. It is difficult to promote a test given the 7 day 'passing' guideline due to issue out of our control.

Prefer introducing tests into the regular pipelines and quarantine for their existing reasons if they are failing. A truly flaky test will get more attention than a new test as there is no additional motivation to give new tests more attention.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

This will likely introduce more failing tests into the pipelines initially that will need to be triaged and appropriately quarantined if necessary.

  • Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Specs reviewed/commented on:

  • browser_ui/3_create/repository/move_project_create_fork_spec.rb
  • browser_ui/3_create/web_ide/review_merge_request_spec.rb
  • browser_ui/6_release/pipeline/parent_child_pipelines_dependent_relationship_spec.rb
  • browser_ui/6_release/pipeline/parent_child_pipelines_independent_relationship_spec.rb
  • browser_ui/7_configure/kubernetes/kubernetes_integration_spec.rb
  • browser_ui/8_monitor/apm/dashboards_spec.rb
  • ee/api/enablement/elasticsearch/advanced_global_advanced_syntax_search_spec.rb
  • ee/api/enablement/elasticsearch/elasticsearch_api_spec.rb
  • ee/browser_ui/8_monitor/apm/metrics_spec.rb
Edited by Zeff Morgan

Merge request reports