Update Jira comment to include more information
What does this MR do?
Issue #195887 (closed)
In !29891 (merged), I added the comment_detail
column.
I was considering splitting into separate backend and frontend MRs but putting them together makes testing easier. Keeping that in mind, this MR includes the following changes:
Backend
- Add the branch name to Jira comments.
- If
comment_detail
is set toall_details
, include more information like commit SHA / MR number and full commit message as described in #195887 (closed). - Add some simple specs and update existing ones.
Frontend
- Expand the Vue component to include the Jira trigger fields.
- Add wrapping component
IntegrationForm
. - Add
JiraTriggerFields
which shows/hides sections based on user selection. - Use translations
Screenshots
GitLab
Jira
Link to Jira issue used for testing (internal)
Entity | Standard | All details |
---|---|---|
Commit | ||
Merge request |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖