Reorganize usage data util methods
What does this MR do?
Reorganize usage data util methods
- Moves the util methods intoto
lib/gitlab/utils/usage_data.rb
- Moves the util specs into
spec/lib/gitlab/utils/usage_data_spec.rb
- Updates the comments for developers to use the utils for count/distinct_count
#212403 (closed)
This is the first another step for "usage data interface"Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Alper Akgun