Skip to content

Disable idle transaction timeout with_lock_retries

What does this MR do?

I was able to reproduce the PRD failure by doing the following:

  1. Configure timeouts in config/database.yml.
development:
  variables:
    statement_timeout: 10000
    idle_in_transaction_session_timeout: 30000
  1. Create a migration that adds a column to projects table.

  2. Lock the projects table in a psql session:

begin;
lock projects IN EXCLUSIVE MODE;

(keep it running)

  1. Run the migration.

  2. At the 11th iteration you should see PG::UnableToSend error

After the fix is applied, the migration is iterating through the loop.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #215866 (closed)

Edited by Yorick Peterse

Merge request reports

Loading