WIP: Geo - Mark unused track registry entries as pending delete
What does this MR do?
The problem with orphaned registries for LFS Objects/Job Artifacts/Uploads records is they do not implement events and rely only on the backfill process. I hope that after we migrate them onto the new framework we can ensure they are properly synced and removed from a secondary Geo node.
My proposal here is to extend the Geo:RegistryConsistencyWorker to mark unused orphaned registries as pending delete. I believe it must be fast enough and should not be responsible for removing the entries and/or files. We can create a cleanup worker to remove these entries and files later if we want.
This is one step forward to remove the Foreign Data Wrapper (FDW) since marking orphaned entries as pending delete allows use the tracking database as the single source of truth because it is easier to exclude them in queries.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team