Skip to content

Update Geo Uploads Filter Nav

Zack Cuddy requested to merge 213219_04-update-uploads-ui into master

What does this MR do?

This is work towards the final product proposed here: #213219 (closed)

This MR focuses on bringing the HAML components for Geo Uploads up to spec with regards to the Filter Bar. This MR is strictly a UI/UX change and no functionality changes.

To do so was simply just removing the old filter nav and replace with the newly created filter nav partial.

As part of this effort, we also removed the Never view as it is no longer supported. To do so, we needed to map never to pending until it is clean up as part of this issue: #216049 (closed)

Screenshots

Old Filter Open (New) Filtered By Status (New) Filtered by Name (New)
Desktop Desktop_-_Old Desktop_-FIlter_Open__New Desktop_-Filtered_by_Status__New Desktop_-Filter_by_Name__New
Mobile Mobile_-_Old Mobile_-Filter_Open__New Mobile_-Filtered_by_Status__New Mobile_-Filter_by_Name__New

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports

Loading