Skip to content

Cop to restrict methods within with_lock_retries

Adam Hegyi requested to merge tweak-with-lock-retries-cop into master

What does this MR do?

  • Eliminate WithLockRetriesWithoutDdlTransaction cop.
  • Introduce a new cop to restrict methods within with_lock_retries

The main goal with this MR is to reduce the amount of rubocop ignores we do when using with_lock_retries.

More context: #206932 (comment 333117488)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Adam Hegyi

Merge request reports

Loading