Add group_deploy_keys table
What does this MR do?
This is a MR to do some preparatory work to add Group Deploy Keys down the road.
This MR introduces the group_deploy_keys
table. Instead of using the existing keys
table, it's been recommended by two reviewers in this MR to create a new table instead.
Unlike the keys
table, this new table won't need STI and therefore won't have a type
column. Instead we'll have a type
method in GroupDeployKey
model that returns "DeployKey"
.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #215160 (closed)
Edited by Etienne Baqué