Resolve "Event tracking not firing for suggest_pipeline experiment"
What does this MR do?
As per https://gitlab.com/gitlab-org/gitlab/-/issues/216306
- Ensures a tracking event is fired when the modal is shown for success.
- Ensures a tracking event is fired when popover is shown for template suggestion.
The current method with use of this.track()
does not seem to be working as advertised and tracking events for those 2 items are currently not firing.
Screenshots
Successful suggest as seen from chrome extension (nudge 2 show)
Successful congratulate as seen from chrome extension (nudge 4 show)
Related tracking event from same popover for nudge 2 show still working - (nudge 3 show)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #216306
Edited by Doug Stull