Pull duplicate EE::SystemNoteService calls into helpers
What does this MR do?
Follow-up from !30880 (comment 336207412).
This file could read better if calls to various system note services are pulled into helpers.
Target branch is set to !30880 (merged) for ease of review & this MR can just follow that MR into master
, as it's not urgent. This should minimize duplicate effort.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry - no functional changes.
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
-
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Yasonik