Resolve "Redirect loop when logging in for the experimental sign_up flow"
requested to merge 215955-redirect-loop-when-logging-in-for-the-experimental-sign_up-flow into master
What does this MR do?
It skips the check_two_factor_requirement
before_action
for the RegistrationsController#welcome
and RegistrationsController#update_registration
actions. This prevents an infinite loop on GitLab.com, when a user requires 2FA from their group. This is caused by:
- User visits
/users/sign_up
and posts form -
RegistrationsController#create
calls therequired_signup_info
before_action
, which leads to a redirect to/users/sign_up/welcome
-
RegistrationsController#welcome
includesEnforcesTwoFactorAuthentication
module and calls thecheck_two_factor_requirement
before_action
, which leads to a redirect to/profile/two_factor_auth
-
Profiles::TwoFactorAuthsController#show
calls therequired_signup_info
before_action
, which leads to a redirect to/users/sign_up/welcome
etc.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #215955 (closed)
Edited by Alex Buijs