Skip to content

Ensure GraphQL SSO Enforcement test can fail

James Edwards-Jones requested to merge jej/fix-graphql-session-enforce-spec into master

What

Ensures that tests in !21922 (merged) can fail if the session is not set.

Results in the following if skip_around_action :set_session_storage is removed from GraphqlController:

Finished in 12.79 seconds (files took 2.53 seconds to load)
3 examples, 2 failures

Failed examples:

rspec ./ee/spec/requests/api/graphql/group_query_spec.rb:32 # getting group information Query group(fullPath) when Group SSO is enforced allows access via session
rspec ./ee/spec/requests/api/graphql/group_query_spec.rb:39 # getting group information Query group(fullPath) when Group SSO is enforced allows access via bearer token

Why

Discovered in !29845 (merged) where a related fix should have caused failures here

Merge request reports