GraphQL: ExternallyPaginatedArrayConnection can return incorrect number of items
requested to merge 216851-graphql-externallypaginatedarrayconnection-can-return-incorrect-number-of-items into master
What does this MR do?
!28446 (merged) rebased ExternallyPaginatedArrayConnection
onto the newer GraphQL::Pagination::ArrayConnection
, but didn't move over the behavior of returning all the nodes in the array, regardless (since the pagination is external).
It's use is currently limited, so it only potentially effected the Resolvers::ErrorTracking::SentryErrorsResolver
Related to #216851 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #216851 (closed)
Edited by Brett Walker