Add terraform reports metrics to usage data
What does this MR do?
- Adds terraform reports metrics to usage data
- Adds an index to
ci_job_artifacts
to optimize collection of the terraform reports metrics
terraform_reports:
Optimization
CREATE INDEX CONCURRENTLY index_ci_job_artifacts_for_terraform_reports ON ci_job_artifacts USING btree (project_id, id) WHERE (file_type = 18)
# The query has been executed. Duration: 25.748 min
DROP INDEX CONCURRENTLY index_ci_job_artifacts_for_terraform_reports
# The query has been executed. Duration: 12.000 ms
Queries
SELECT MIN("ci_job_artifacts"."id") FROM "ci_job_artifacts" WHERE "ci_job_artifacts"."file_type" = 18
Before: https://explain.depesz.com/s/WqtE
After: https://explain.depesz.com/s/bIhv
SELECT MAX("ci_job_artifacts"."id") FROM "ci_job_artifacts" WHERE "ci_job_artifacts"."file_type" = 18
Before: https://explain.depesz.com/s/tftj
After: https://explain.depesz.com/s/O3yM
SELECT COUNT("ci_job_artifacts"."id") FROM "ci_job_artifacts" WHERE "ci_job_artifacts"."file_type" = 18 AND "ci_job_artifacts"."id" BETWEEN 0 AND 999999
Before: https://explain.depesz.com/s/DEte
After: https://explain.depesz.com/s/lWtC
projects_with_terraform_reports:
Optimization
CREATE INDEX CONCURRENTLY index_ci_job_artifacts_for_terraform_reports ON ci_job_artifacts USING btree (project_id, id) WHERE (file_type = 18)
# The query has been executed. Duration: 25.748 min
DROP INDEX CONCURRENTLY index_ci_job_artifacts_for_terraform_reports
# The query has been executed. Duration: 12.000 ms
Queries
SELECT MIN("ci_job_artifacts"."project_id") FROM "ci_job_artifacts" WHERE "ci_job_artifacts"."file_type" = 18
Before: https://explain.depesz.com/s/KEgV
After: https://explain.depesz.com/s/dtK7
SELECT MAX("ci_job_artifacts"."project_id") FROM "ci_job_artifacts" WHERE "ci_job_artifacts"."file_type" = 18
Before: https://explain.depesz.com/s/GBRv
After: https://explain.depesz.com/s/KDg8
SELECT COUNT(DISTINCT "ci_job_artifacts"."project_id") FROM "ci_job_artifacts" WHERE "ci_job_artifacts"."file_type" = 18 AND "ci_job_artifacts"."project_id" BETWEEN 0 AND 999999
Before: https://explain.depesz.com/s/JmKV
After: https://explain.depesz.com/s/eNJT
Migration outputs
Up
== 20200512160004 AddIndexToCiJobArtifactsForTerraformReports: migrating ======
-- transaction_open?()
-> 0.0000s
-- index_exists?(:ci_job_artifacts, [:project_id, :id], {:where=>"file_type = 18", :name=>"index_ci_job_artifacts_for_terraform_reports", :algorithm=>:concurrently})
-> 0.0033s
-- add_index(:ci_job_artifacts, [:project_id, :id], {:where=>"file_type = 18", :name=>"index_ci_job_artifacts_for_terraform_reports", :algorithm=>:concurrently})
-> 0.0069s
== 20200512160004 AddIndexToCiJobArtifactsForTerraformReports: migrated (0.0109s)
Down
== 20200512160004 AddIndexToCiJobArtifactsForTerraformReports: reverting ======
-- transaction_open?()
-> 0.0000s
-- indexes(:ci_job_artifacts)
-> 0.0041s
-- remove_index(:ci_job_artifacts, {:algorithm=>:concurrently, :name=>"index_ci_job_artifacts_for_terraform_reports"})
-> 0.0034s
== 20200512160004 AddIndexToCiJobArtifactsForTerraformReports: reverted (0.0080s)
Closes #207532 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides - [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖