Move out VSA summary value formatting from the serializer
What does this MR do?
Move out VSA summary value formatting logic from the serializer and from the query objects.
Classes:
-
NoValue
=>-
-
NumericValue
=> string representation of the number -
PrettyNumeric
(couldn't find better name) => string representation of the number, if the number is 0, show-
Note: most of the formatting functionality is tested in integration
./ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary_spec.rb
./ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_time_summary_spec.rb
./ee/spec/controllers/analytics/cycle_analytics/summary_controller_spec.rb
./spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Closes #214677 (closed)
Edited by Peter Leitzen