Skip to content

Move out VSA summary value formatting from the serializer

Adam Hegyi requested to merge 214677-improve-vsa-summary-values into master

What does this MR do?

Move out VSA summary value formatting logic from the serializer and from the query objects.

Classes:

  • NoValue => -
  • NumericValue => string representation of the number
  • PrettyNumeric (couldn't find better name) => string representation of the number, if the number is 0, show -

Note: most of the formatting functionality is tested in integration

  • ./ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_summary_spec.rb
  • ./ee/spec/lib/gitlab/analytics/cycle_analytics/summary/group/stage_time_summary_spec.rb
  • ./ee/spec/controllers/analytics/cycle_analytics/summary_controller_spec.rb
  • ./spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #214677 (closed)

Edited by Peter Leitzen

Merge request reports

Loading