Loosen prop requirement
What does this MR do?
When a project has no pipeline data, we display an information about how to setup vulnerability scanning in the security dashboard. That view is not using some props that are defined as required. Although there is no visual bug, we do log into the console an error message. This MR fixes those error messages by loosening the prop requirement.
In order to reproduce it in both security dashboards:
- Pick a project that has no pipeline data
- Visit the Security & Compliance tab on the left.
- Open your console, if you have the feature flag (:first_class_vulnerabilities) enabled locally, you should see an error message (if you check out this branch you'll see that the error message is gone).
- If you disable the feature flag, you'll be shown the REST API backed security dashboard. In that case, you'll see a similar error on master branch.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #211827 (closed)
Edited by Savas Vedova