Adjust wrong reactive cache workers retry amount
What does this MR do?
Context
The fact that models/concerns
are loaded before initializers
(for production) led to a bug where an early evaluation of these modules (and cascading to evaluation of ReactiveCachingWorker
and ExternalServiceReactiveCachingWorker
) would use an
outdated Sidekiq.sidekiq_options
(which is set to retry: true
by default on Sidekiq).
This allow these workers in production to retry up to 25 times, spending quite some time doing it.
In summary, the bug consisted in:
- These worker classes were initialized with
retry: true
Sidekiq configuration, given theinitializers/sidekiq.rb
wasn't evaluated yet - The initializer set the default properly
- The subsequently loaded workers would get the right default
gitlab-com/gl-infra/scalability#356 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
Edited by Oswaldo Ferreira