Skip to content

Fix insights notice text with YAML anchors

Adam Hegyi requested to merge fix-insights-note-bug into master

What does this MR do?

This MR fixes the notice text on the insights page when there are filtered out charts/items.

Bug:

When the insights YAML file contains anchors, the #notice_text method wrongfully detects "difference" in the config (items filtered out).

Example:

projectsOnly: &projectsOnly # anchor, should be ignored when comparing original and filtered out config
  projects:
    only:
      - 4359271
page1: # valid page configuration
  title: hi
  charts:
    ...
page2: # valid page configuratiuon
  title: hi
  charts:
    ...

Expected:

  • Do not show the notice text.

Current:

  • It shows the notice text because the original config differs from the filtered out config.

Resources

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Adam Hegyi

Merge request reports

Loading