Skip to content

Resolve "Make Group level activity analytics available for Bronze and above tiers on gitlab.com"

Pavel Shutsin requested to merge 214664-fix-beta-feature-check into master

What does this MR do?

It fixes a bug with Group#beta_feature_available? check. Old behavior ignores license rules even when feature is enabled globally, while new behavior allows feature to be enabled per group for beta test or enable it globally to allow general usage.

This will allow us to make group level activity available for general audience at GitLab.com

Technical details

::Feature.enabled?(feature, self) returns true if feature is enabled for a group OR globally, so license check never happened.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #214664 (closed)

Edited by Pavel Shutsin

Merge request reports

Loading