Skip to content

Fix admin setting bug for protected variables

Payton Burdette requested to merge fix-protected-vars-by-default into master

What does this MR do?

This MR fixes the issue where a user enables variables to be protected by default in the Admin settings. When this setting is set, now the variables will be protected by default only when creating a new variable.

Related to: #217394 (closed)

Screenshots

Note the global setting behind the modal.

Before After
Screenshot_2020-05-12_at_13.27.12 Screenshot_2020-05-12_at_13.28.30

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Ragnar Hardarson

Merge request reports

Loading