Fix missing space on system notes
What does this MR do?
A follow up for: #217310 (closed)
We are adding a selection of margin classes to the system-note-separator to ensure a flush layout when using a inline layout on the note_header.vue.
We also remove the extra mr-1 from noteable_note.vue as it creates extra spacing to the right with comments.
This allows us to have the confidential icon kept in the code base and does not cause any visual regressions for the system notes.
Screenshots
Non-Confidential
| lg | md | sm | xs |
|---|---|---|---|
 |
 |
 |
 |
Confidential
| lg | md | sm | xs |
|---|---|---|---|
 |
 |
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by David O'Regan