Skip to content

Persist banner dismissal

Savas Vedova requested to merge 213671-persist-storage-to-db into master

What does this MR do?

Persists the dismissal of the introduction banner in the database. Previously we were using cookies for the dismissal. This MR changes this behaviour and it uses the user callout endpoint to persist it in the database. Since there may be users who already dismissed the banner, this MR also provides backward compatibility by reading the cookie value (but for new sessions it won't set the cookie anymore).

The related issue is described here: #213671 (closed)

Screenshots

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading