Skip to content

Add nested file detection for Dependency Scanning

Igor Frenkel requested to merge fix-nested-search-for-matching-ds-files into master

What does this MR do?

This MR is a fix for !30784 (merged)

Note that exists rules support globbing but using fnmatch which doesn't really support regexes. So in order to test matching up to a depth of 2, the {Gemfile.lock,*/Gemfile.lock,*/*/Gemfile.lock} rule was the best matcher I could find. I did not use the **/Gemfile.lock glob because that would change the behaviour of Dependency Scanning on projects that formerly did not have a detection on matching files at depth >2 but all of a sudden start getting detections.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Yorick Peterse

Merge request reports

Loading