Skip to content

StaticModel equality simplification

Alex Kalderimis requested to merge ajk-static-eq into master

What does this MR do?

This MR simplifies StaticModel equality checks.

The previous implementation was both more complex than it needed to be, and could be a source of bugs. Since equality is symmetric, we never need to call super.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Kalderimis

Merge request reports

Loading