Skip to content

Remove extra full stop character from Danger message

What does this MR do?

A full stop is already added to the Danger message in https://gitlab.com/gitlab-org/gitlab/blob/653202fdcf9cca72a3e10e07a1825c6bf360b6f5/danger/commit_messages/Dangerfile#L24, thus ending with a full stop in the commit_linter causes the message to have 2 full stops.

Screenshots

Screen_Shot_2020-05-18_at_14.05.15

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading