Skip to content

Make Geo Node Url more Prominent

Zack Cuddy requested to merge 214467-make-node-url-prominent into master

What does this MR do?

Closes #214467 (closed)

Currently the Geo Node URL isn't a link. However, it is a valid url and users are expecting it to be clickable.

This turns it from a <span> to <gl-link>

Important Note: The bootstrap font-weight was heavier than the Pajama's font weight. On this MR I converting the classes to GitLab's classes and in turn caused the font-weight to lighten just a tad.

Screenshots

Geo Node Url
before Screen_Shot_2020-05-18_at_3.10.57_PM
after Screen_Shot_2020-05-19_at_12.54.31_PM

GIF

Kapture_2020-05-18_at_14.57.26

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #214467 (closed)

Edited by Yorick Peterse

Merge request reports

Loading