Skip to content

Whitelist `gl-emoji` element in tooltips

What does this MR do?

See #28589 (closed)

Fixes emojis in user statuses. The Bootstrap Tooltip sanitizes HTML used in tooltips and has a white list of allowed tags and attributes. Previously the HTML attributes on the gl-emoji element were being stripped out which prevented emojis from rendering. This MR adds gl-emoji and required HTML attributes to that list so emojis inside tooltips are now rendered.

Screenshots

Before After
Screen_Shot_2020-05-19_at_2.26.33_PM Screen_Shot_2020-05-19_at_2.26.01_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports

Loading