Skip to content

Update ActiveToggle and JiraTriggerFields with new form layout

What does this MR do?

Issues #215086 (closed) and #214865 (closed)

  • Update ActiveToggle and JiraTriggerFields with new form layout: From label side-by-side the input in a 2:10 column layout (old form) to label above input spanning the whole width (GitLab UI). This is put behind the feature flag integration_form_refactor which includes changes from previous MRs on the rest of the form.
  • Add form validations to the DynamicField component to follow old behaviour in specs.
  • Remove stubs that disable the integration_form_refactor feature flag in specs to make sure they pass. Made some minor changes (enable JS for specs, copy changes, change selectors) to make sure they are still passing (no change in actual behaviour).
  • This is the final MR before we enable the feature flag. We will roll out this change, make sure things still work then cleanup.

Screenshots

Integration Before (without ff enabled) After (with ff enabled)
Asana Screenshot_2020-05-21_Asana___Integrations___Settings___Gitlab_Org_Gitlab_Shell_1_ Screenshot_2020-06-05_Asana___Integrations___Settings___Gitlab_Org_Gitlab_Shell
Jira Screenshot_2020-05-21_Jira___Integrations___Settings___Gitlab_Org_Gitlab_Shell_1_ Screenshot_2020-06-05_Jira___Integrations___Settings___Gitlab_Org_Gitlab_Shell

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading