WIP: (Prototype) Update Tf Plan Error Messages
What does this MR do?
Currently, the Tfplan
class obtains JSON from the customer and uses the JSON to generate a terraform artifact.
Since the JSON is generated by the customer, there are a lot of issues related to generating the report.
There is also a semi-related epic about how GitLab should send better error messages to the customer.
The MR will:
- Remove the
valid_supported_keys?
validation. Even if the JSON parse fails, we should still allow thejob_path
field to create and generate a button for the customer. - Update TfPlan error text to include better errors messages and a link to the documentation
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖