Skip to content

New/unknown sign-in email email styling

Drew Blessing requested to merge dblessing-new-sign-in-email-beautification into master

What does this MR do?

Relates to #218443 (closed) (and sort of #215652)

Makes the unknown/new sign in email look more legitimate and clarifies what's happened.

Although the unknown sign in feature has been mostly working as intended, we have had some user feedback. The 'plain text' nature of the email was suspicious to some and they thought it was phishing. Others were confused by where they had actually signed in since the GitLab hostname (gitlab.com) wasn't especially prominent.

This change attempts to unify the email with an established email styling. We currently use this format for the pipeline and merge request approval emails. I'm no frontend developer or UX designer so I am sure this needs some fine tuning but it's something to start from.

Screenshots

Screen_Shot_2020-05-22_at_2.03.55_PM

Modeled from

Screen_Shot_2020-05-21_at_5.44.49_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Drew Blessing

Merge request reports

Loading