Skip to content

Remove search icon from Project find file button

Taurie Davis requested to merge 25830-find-file-button into master

What does this MR do?

This MR removes the icon from the Find file button on the Project details view.

We are removing this icon because there was some confusion over whether to use the search bar in the header vs. the search button on the detail view. Since the magnifying glass icon is often attributed to the search action in an input, we've decided to remove the icon from the button since clicking the button does not perform a search.

Screenshots

Before After
Screen_Shot_2020-05-27_at_9.56.38_AM Screen_Shot_2020-05-27_at_9.56.30_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #25830 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading