Move jquery.waitforimages import away from main
What does this MR do?
Move jquery.waitforimages import away from main
This moves the import of jquery.waitforimages
from main to
app/assets/javascripts/commit/image_file.js
app/assets/javascripts/pages/projects/show/index.js
app/assets/javascripts/pages/projects/tree/show/index.js
These are the only files which utilize it and thus we don't need to load it on every page.
The issue to replace it completely can be found here: #219370 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas Eipert