Skip to content

Abstract html tables into seperate components

Justin Boyson requested to merge jdb/refactor-diff-html-tables into master

NOTE DO NOT USE THIS MR

There are too many changes that overlap from master. I'm keeping this around for reference, but this MR will need to be recreated from scratch to make sure nothing gets missed.

What does this MR do?

This is a small refactor to move HTML table markup "up" out of some child components. This is a predatory step to refactoring off of HTML tables completely which is itself in service to enhance the UX of selecting multiline comments.

Specifically, this moves all td tags "up" to their parent tr components and moves "should render" logic up to the parent table component where it was easy to do so. This MR also moves the "parallel" and "inline" table components into their own respective child components to make it easier to toggle in CSS based layout components in the future.

Screenshots

n/a

Does this MR meet the acceptance criteria?

Conformity

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading