Skip to content

Add hovering icon for sorting columns on alert management list

Laura Montemayor requested to merge lm-hover-state-sort into master

What does this MR do?

Adds the hover state for sorting columns in the Alert Management List.

Screenshots

2020-06-10_20.18.58

Follow-up issues:

  1. Disable pointer + other CSS: gitlab-ui#795
  2. Update docs and add props for table: gitlab-ui#794
  3. Fix jumpiness: gitlab-ui#835 (closed)

A note on the CSS added here:

After much discussion with UX, we have decided to keep the arrows, so I re-opened this MR. You can see a full discussion here: !34103 (closed)

TLDR: We tried doing the most boring solution (straight out replace icons) but it didn't work out, as it's not the best user experience. The icons are more visual than they are "workable" for clicking up and down, so we decided to go with the arrows. Please read the issue above for more details.

There is some CSS technical debt that is included in this MR. It will be extracted out of this MR and into gitlab-ui as a follow up issue, to make it consistent with the rest of the tables that are sortable. Right now, we only have one other sortable table, but it's sortable by only one column, so the hovering wouldn't even apply there.

#218571 (closed)

Edited by Rémy Coutable

Merge request reports

Loading