fix: avoid javascript for omniauth logins
What does this MR do?
When a user clicks on an Omniauth login icon (e.g. Google), Rails will translate a link_to URL from a GET to a POST form submission via JavaScript. However, if JavaScript is disabled or not loaded before the page loads, this will cause a GET request to go to the login provider instead of POST, resulting in a 404.
To avoid this, we use button_to instead of link_to. button_to will set a form submission with a POST request without JavaScript.
Closes #28904 (closed)
Screenshots
Before (using link_to generating a elements)
After (using button_to generating form and button)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Diego Louzán