Skip to content

Change `commits_by_message` to not mutate string parameters

What does this MR do?

In #219546 (closed), it was noted that CommitService#commits_by_message mutates some of the string arguments it receives. This could cause unexpected errors because all string literals are frozen (!33216 (comment 351391995)).

This MR alters commits_by_message to duplicate strings before changing them, so that we don't encounter these types of errors.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #219546 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading