Change `commits_by_message` to not mutate string parameters
requested to merge 219546-change-commits_by_message-encoding-method-to-not-mutate-string into master
What does this MR do?
In #219546 (closed), it was noted that CommitService#commits_by_message
mutates some of the string arguments it receives. This could cause unexpected errors because all string literals are frozen (!33216 (comment 351391995)).
This MR alters commits_by_message
to duplicate strings before changing them, so that we don't encounter these types of errors.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Closes #219546 (closed)
Edited by 🤖 GitLab Bot 🤖