Follow-up from "Add "Type" field to asset links on "Edit Release" page
requested to merge 219391-follow-up-from-add-type-field-to-asset-links-on-edit-release-page into master
What does this MR do?
The spacing between the form elements in the Links section of the Edit Release page does not comply with the Pajamas guidelines.
Because .row
is being used here, the padding/gutter applied is 15px
instead of 16px
.This MR removes the negative margins from .row
and the horizontal padding from all immediate children columns by applying the .no-gutters
class, and then apply the correct spacing modifiers to the form groups.
Screenshots
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #219391 (closed)
Edited by Rayana Verissimo