Skip to content

[RUN AS-IF-FOSS] RSpec zero monkey patching mode

Arturo Herrero requested to merge 220018-rspec-zero-monkey-patching-mode-18 into master

What does this MR do?

The plan for RSpec 4.0 is to disable monkey patching: https://rspec.info/blog/2013/07/the-plan-for-rspec-3/#zero-monkey-patching-mode

This commit stops using RSpec monkey patching in several spec files: https://relishapp.com/rspec/rspec-core/docs/configuration/zero-monkey-patching-mode

This is part of a series of merge requests until we are able to configure RSpec to raise a method missing error to prevent this to happen anymore:

RSpec.configure do |config|
  config.disable_monkey_patching!
end

It's difficult to review this but a nice way could be to checkout the branch locally and grep filter for changes different from:

- describe
+ RSpec.describe

Something like this:

git diff HEAD^ | grep '^[+-][A-z\w]' | grep -vE '\-describe|\+RSpec.describe'

Related to #220018 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading