Skip to content

Use ProxyVariableSubstitutionService for variable substitution in alerts

Reuben Pereira requested to merge 220144-substitute-variables-in-alerts into master

What does this MR do?

Use the Prometheus::ProxyVariableSubstitutionService service to substitute variables in alert queries. This is the same service that is used to substitute variables in metrics. This puts alerts on par with metrics. Using the same service ensures that any change in variable substitution logic that affects alerts will be caught by alert specs.

Issue: #220144 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading