Remove schema compatibility fixes for PG 9.6
What does this MR do?
This removes compatibility fixes we introduced to support PG 9.6, while gdk was on PG11. Now that we can safely assume >= PG11 everywhere (also in CI), we can drop those fixes:
- Explicit
plpgsql
extension - we don't need to be explicit here anymore, this is present by default and pg_dump (from >=PG11) doesn't explicitly dump that anymore either. -
CREATE SEQUENCE ... as integer
- this wasn't compatible syntax-wise with PG9.6.
(1) gets rid of this warning when resetting the gdk database:
psql:/home/abrandl-gl/workspace/gdk/gitlab/db/structure.sql:3: NOTICE: extension "plpgsql" already exists, skipping
For (2) - I'm surprised as datatype
doesn't show up in db/structure.sql
after running rake db:structure:dump
with the adjusted SchemaCleaner
. Not sure exactly why that is - perhaps meanwhile something changed in Rails.
For reviewers: Can you please confirm a rake db:structure:dump
doesn't produce changes in your local db/structure.sql
? Specifically not for the sequences?
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team